|From:||Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>|
|To:||igor polishchuk <ora4dba(at)gmail(dot)com>|
|Subject:||Re: INSERT and parentheses|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2010-08-24 8:25 AM +0300, igor polishchuk wrote:
> Marko et al,
> This is my first ever attempt of a patch review just for learning the
> procedure. I'm not a postgres developer, so the review is partial and mostly
> from the usability prospective.
That's all right. I'm sure any help is appreciated.
> The patch provides a HINT for unclear error. This should clarify for a user
> what exactly is wrong with the sql.
> However, the actual HINT text provided with the patch is not very clear,
> The Stephen Frost's suggestion would add clarity:
> errhint("insert appears to be a single column with a record-type rather than
> multiple columns of non-composite type."),
This isn't entirely accurate, either; the columns are not necessarily of
|Next Message||Andrew Dunstan||2010-08-24 08:53:24||Re: WIP: extensible enums|
|Previous Message||Heikki Linnakangas||2010-08-24 08:42:49||Re: Interruptible sleeps (was Re: CommitFest 2009-07: Yay, Kevin! Thanks, reviewers!)|