Re: GSoC database modeler [Luis Ochoa]

Le 16/08/2010 22:40, Thom Brown a écrit :
> On 16 August 2010 21:05, Luis Ochoa <ziul1979(at)gmail(dot)com> wrote:
>> Hi, this is my patch for GSoC 2010 database designer for pgAdmin, I hope it
>> likes you, I have done a lot of work to create this modeler, but even with
>> all that work, is unfinished and lacks of a lot of things, but I believe
>> that it will be ready in a professional way in a few months.
>>
>> This is a patch for the git repository, it have been tested at windows &
>> linux.
>>
>> you can watch in action (windows) here:
>>
>> http://www.youtube.com/watch?v=RbXIuyTIpJ0
>>
>> Regards, Luis.
>>
>
> Hi Luis,
>
> Nice progress. :) I notice that if you create a new table and then
> create a foreign key on it from another table, the datatype on the new
> table is undefined. Couldn't that default to the same datatype as the
> primary key? (but obviously if the PK is serial/bigserial then it uses
> int/bigint)
>

I think we need to get rid of the "undefined" pseudo-type. I would like
to change the "Add column" menu item to show a dialog with a text box to
enter the name of the column and a combobox to choose the type (and
precision too in case of varchar and numeric type).

> I still think one thing which definitely needs changing are the
> controls. Most of them cover a very small pixel area and as such make
> it tricky to click on and prone to missing them (or at least it would
> be for me).

Well, I also think we should get rid of them. Every action should start
within the contextual menu. No Add or Delete button. And I don't really
like the "double click" to rename an object. We should use the
contextual menu once again

> Although I appreciate you're still in the middle of
> working on everything and are just working on functionality rather
> than presentation.

Actually, it's the end of the GSoC. I think Luis still wants to work on
it, and I really hope so.

> Also, could the play button (which currently shows the SQL) just say
> "SQL" on it?

Yes, that would be best. The "play" button is the execute button on the
Query Tool. Quite confusing.

> And for it to appear in a separate panel in the same window?

We'll probably have to get rid of the notebook and have two panes, one
to draw the schema, one to see the SQL. They can both have a toolbar. On
the draw pane, we could have load, save, sql buttons. On the SQL pane,
we could have save, run, open query tool.

> Sort of like results currently do for the SQL Query Editor in
> PgAdmin. In fact, maybe if the pane is open and you make changes to
> the diagram, it could update the pane contents in real time?
>

Yeah, could be possible.

The last item we should not forget is a reverse engineer button. I've
read some parts of the code Luis wrote, and I think it should be pretty
easy to do. AFAICT, it's a one day job, considering all the foundations
built by Luis.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com