Re: GSoC - Patch (Schema Difference Sync+ Visualization)

Le 16/08/2010 19:34, adeel khan a écrit :
> One thing i forgot to mention, the patch is against svn , extremely sorry
> for this as i have issues with git and could'nt find time to think about it.
>

AFAICT, it applies cleanly.

>> Hi Everyone!
>> Hope you are fine. Well here it is what i can say some what the final
>> version of my two and half month coding activity. I have managed to complete
>> almost all of my use cases except just one and that also do not require a
>> lot of work as i have the base code there but unfortunately not the time.
>> Any how here is my work , i would like you to please check it and give me
>> your feedback, what value additions could be made or else. I have tried to
>> manage sync possibilities i can think of for tables and views and tested it
>> , but now please do check it and let me know about it with the example
>> script that is causing the error.
>> I must admit here that there are still a lot of issues i can think about
>> which need fixing , specially of optimization, some code that could surely
>> be written in a better way and UI thing (specially the sizer) .
>>
>> BTW i have tested it for windows , sorry for the linux/mac people
>>

The real issue is here, with the gcc compiler. Well, it's more your code
than gcc. There are loads and loads of errors and warnings. I already
fixed a few ones :

* for the xpm files, "static char*" should be "static const char*"
* #endif should not have a semicolon at the end
* #include"" doesn't work, you need a space between the #include
keyword and the file path
* there's no pgadmin3.h, it should be replaced with pgAdmin3.h (notice
the upper A)
* svFkDiff.h is not the same thing than svFKDiff.h (notice the upper K)

I don't need to continue, I think you got my point. Even with all these
fixes, I still get tons of warnings and errors. Seems there are a lot of
work still to do.

--
Guillaume
http://www.postgresql.fr
http://dalibo.com