Re: unused_oids script is broken with bsd sed

From: Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unused_oids script is broken with bsd sed
Date: 2018-04-25 14:28:55
Message-ID: 4C2BAD24-99E6-4C45-AFA2-1A8949D32D69@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 25 Apr 2018, at 17:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> +many for rewriting in perl. Do you want to have a go at that? If not I
>> will.
>
> +1 ... I was mildly astonished that this didn't already have to happen
> as part of the bootstrap data conversion effort. It's certainly not
> hard to imagine future extensions to the .dat file format that would
> break this script, and duplicate_oids too. I think we should rewrite
> both of them to use the Catalog.pm infrastructure.
>
> regards, tom lane

Hm, I attached patch in first message, but seems that my mail client again
messed with attachment. However archive caught it:

https://www.postgresql.org/message-id/attachment/60920/0001-Rewrite-unused_oids-in-perl.patch

--
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2018-04-25 14:34:47 Re: Built-in connection pooling
Previous Message Tom Lane 2018-04-25 14:18:37 Re: unused_oids script is broken with bsd sed