Re: pg_dump's checkSeek() seems inadequate

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump's checkSeek() seems inadequate
Date: 2010-06-28 01:25:18
Message-ID: 4C27F9FE.10209@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> A somewhat more plausible scenario is that somebody might hope that
> they could do something like this:
>
> echo 'some custom header' >pg.dump
> pg_dump -Fc >>pg.dump
>
> I believe that (at least on most Unixen) doing fseeko(fp, 0, SEEK_SET)
> would result in overwriting the custom header, where it would not have
> been overwritten before. However the usefulness of the above is at
> best far-fetched; and I'm not very sure that it works today anyway,
> since pg_dump/pg_restore seem to assume that manual byte counting should
> match the results of ftell().
>
>
>

What would anyone hope to achieve by such a manoeuvre, even if it
worked, which I am close the dead sure it would not?

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-06-28 02:24:21 Re: pg_dump's checkSeek() seems inadequate
Previous Message Tom Lane 2010-06-28 01:02:58 Re: suppress automatic recovery after back crash