Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Hartmut Goebel <h(dot)goebel(at)goebel-consult(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Kevin Grittner <kevin(dot)grittner(at)wicourts(dot)gov>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Date: 2010-06-10 13:02:03
Message-ID: 4C10E24B.8030105@kaltenbrunner.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hartmut Goebel wrote:
> Am 07.06.2010 02:32, schrieb Robert Haas:
>
>> But we will likely add more
>> keywords at some point in the future, and while providing an output
>> format that quotes everything won't fix every potential problem, it
>> might make life easier for some people.
>
> +10
>
> Exactly my point: Make life easier for others. Admins have a hard job
> anyway.

I for myself would be rather annoyed if we started quoting all column
names in our dumps. This is seriously hampering readability and while it
is already annoying that pg_dump output is slightly different from the
original DDL used this would make it far worse.
I'm also not convinced that this is a good idea at all, using keywords
like that is always an issue and forward portability of dumps in general
is imho a pipe dream

>
> BTW: mysql does a far better job here.

not sure I agree here but well...

Stefan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2010-06-10 13:21:45 Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading
Previous Message Hartmut Goebel 2010-06-10 12:54:12 Re: BUG #5488: pg_dump does not quote column names -> pg_restore may fail when upgrading