Re: PATCH: FB#15614: Use CALL for callable statements

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: FB#15614: Use CALL for callable statements
Date: 2010-05-27 10:20:28
Message-ID: 4BFE476C.9030806@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 27/05/2010 11:32, Dave Page a écrit :
> Thanks - patch applied.
>
> On Thu, May 27, 2010 at 10:22 AM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>> Hi Dave,
>>
>> Please find the patch for the same.
>> This is valid for both trunk and REL-1_10 patch.
>>

Are we sure that the dlgDirectDbg::invokeTargetCallable() method is only
called when connected to an EDB server? I didn't work a lot with the
debugger frontend source code, but it seems to me that this function can
be called even with vanilla PostgreSQL servers, especially on Windows
(see dlgDirectDbg::invokeTarget() method). Am I wrong?

--
Guillaume
http://www.postgresql.fr
http://dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2010-05-27 10:21:26 [pgAdmin III] #196: Use CALL for callable statements
Previous Message Dave Page 2010-05-27 09:32:29 Re: PATCH: FB#15614: Use CALL for callable statements