Re: pg_upgrade and extra_float_digits

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade and extra_float_digits
Date: 2010-05-16 17:11:05
Message-ID: 4BF02729.2020401@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>
>> Andrew Dunstan wrote:
>>
>>> But do earlier server versions accept a value of 3? The 8.4 docs say
>>> "The value can be set as high as 2".
>>>
>
>
>> That is the other thing I had to hack --- the 8.4 backend version had to
>> be changed to accept '3'. The good thing is this has to be done only
>> once --- once I have the dump file, I can use it in testing repeatedly
>> because 8.4 does not change.
>>
>
>
>> Eventually the idea would be to have the build farm run such tests (with
>> a properly created dump file) so we can learn quickly if the backend
>> data format is changed.
>>
>
> If we're thinking of doing that, it would be better to back-patch the
> change that allowed '3'.
>
>
>

Yeah.

It's going to require some fancy dancing to get the buildfarm to do it.
Each buildfarm run is for a specific branch, and all the built artefacts
are normally thrown away. I'd have to work out a way of stashing the
binaries from a build on one branch for use in the pg_upgrade tests in
the run on another branch. It's doable but could get messy.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-05-16 17:11:20 Re: Performance problem in textanycat/anytextcat
Previous Message Robert Haas 2010-05-16 16:35:45 Re: Performance problem in textanycat/anytextcat