Re: recovery.conf.sample

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: recovery.conf.sample
Date: 2010-04-06 14:55:05
Message-ID: 4BBB4B49.30903@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> recovery.conf.sample has the following section for Hot Standby.
>> Is this still required?
>>
>>> #---------------------------------------------------------------------------
>>> # HOT STANDBY PARAMETERS
>>> #---------------------------------------------------------------------------
>>> #
>>> # If you want to enable read-only connections during recovery, enable
>>> # recovery_connections in postgresql.conf
>>> #
>>> #---------------------------------------------------------------------------
>>
>> Heikki classified the recovery options into the following three
>> groups, in the document.
>>
>> 26.1. Archive recovery settings
>> 26.2. Recovery target settings
>> 26.3. Standby server settings
>>
>> OTOH, recovery.conf.sample has classified them into the following
>> two groups. This is inconsistent with the document, and looks
>> confusing. How about modifying recovery.conf.sample to make the
>> grouping the same?
>>
>> ARCHIVE RECOVERY PARAMETERS
>> LOG-STREAMING REPLICATION PARAMETERS
>
> The attached patch removes the unnecessary section about HS from
> recovery.conf.sample. Also it changes the grouping of parameters
> in recovery.conf.sample as mentioned above.

I committed the "LOG-STREAMING REPLICATION PARAMETERS" -> "STANDBY
SERVER PARAMETERS" rename. Simon added the "RECOVERY TARGET PARAMETERS"
heading already, and he wants to keep the Hot Standby section.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2010-04-06 15:05:13 Re: Proposal: Add JSON support
Previous Message Mike Rylander 2010-04-06 14:53:39 Re: Proposal: Add JSON support