Re: pending patch: Re: Streaming replication and pg_xlogfile_name()

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pending patch: Re: Streaming replication and pg_xlogfile_name()
Date: 2010-04-06 10:25:13
Message-ID: 4BBB0C09.1050708@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao wrote:
> On Fri, Apr 2, 2010 at 2:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Can someone explain to me in plain language what problem this is
>> trying to fix? I'm having trouble figuring it out.
>
> The problem is that pg_xlogfile_name(pg_last_xlog_receive_location()) and
> pg_xlogfile_name(pg_last_xlog_replay_location()) might report an inaccurate
> WAL file name because currently pg_xlogfile_name() always uses the current
> timeline to calculate the WAL file name. For example, even though the last
> applied WAL file is 000000010000000000000002, the standby wrongly reports
> that 000000000000000000000002 has been applied last.

Should we throw an error in pg_xlogfile_name() if called during
recovery? It's not doing anything useful as it is.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2010-04-06 11:02:54 Re: pending patch: Re: Streaming replication and pg_xlogfile_name()
Previous Message Dimitri Fontaine 2010-04-06 10:11:32 Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per