Re: Missing non-login roles in properties dialog

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Erwin Brandstetter <brandstetter(at)falter(dot)at>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Missing non-login roles in properties dialog
Date: 2010-04-05 07:21:52
Message-ID: 4BB98F90.5000908@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Le 04/04/2010 22:35, Erwin Brandstetter a écrit :
> On 04.04.2010 22:10, guillaume(at)lelarge(dot)info wrote:
>> Le 04/04/2010 21:39, Erwin Brandstetter a écrit :
>>
>>> Hi developers!
>>>
>>> Seeing as Guillaume is on a roll, fixing bugs faster than I can open new
>>> tickets, I have found one more, in a feeble attempt to keep up.
>>>
>> Thanks :)
>>
>>
>>> Group roles are missing for the "Owner" field of properties dialogs.
>>>
>> You probably forgot the "Show users for privileges" preference in the
>> Options dialog.
>>
>
> Nope, I don't think we will get away that easily. :p
> I had that option checked, and it works the other way round, too: user
> (login) roles are added to the drop-down "Role", "Privileges" tab.
> The new bug concerns missing group (non-login) roles in the "Owner"
> field, "Properties"-tab.
>

You're definitely right. Next time, I'll read more carefully your bug
report :/

Anyways, here is a patch to fix this. Do we need an option to
enable/disable this behaviour? I think not, but, as we have one for
priviledges, prefer to ask first before commiting it.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
ticket164_v1.patch text/x-patch 5.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message pgAdmin Trac 2010-04-05 07:22:18 Re: [pgAdmin III] #164: Missing non-login roles in properties dialog
Previous Message pgAdmin Trac 2010-04-04 22:06:35 Re: [pgAdmin III] #134: Can't change the storage information of a column