Re: pgindent bizarreness

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: pgindent bizarreness
Date: 2010-04-05 03:14:11
Message-ID: 4BB95583.7080209@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
>
>> Why has pgindent decided to screw up all the FD_SET calls in our code?
>> See for example
>> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/pgstat.c.diff?r1=1.188;r2=1.189
>>
>
> Because the typedef list supplied by Andrew includes FD_SET as a
> typedef. :-O See src/tools/pgindent/typedefs.list.
>

I've committed a fix to pgindent for this. Do we want to rerun pgindent
for these files?:

src/test/examples/testlibpq2.c
src/interfaces/libpq/fe-misc.c
src/backend/postmaster/syslogger.c
src/backend/postmaster/pgstat.c
src/backend/postmaster/postmaster.c
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
src/backend/port/win32/socket.c
src/backend/libpq/auth.c
contrib/pgbench/pgbench.c

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-04-05 03:15:18 Re: pgindent bizarreness
Previous Message Andrew Dunstan 2010-04-05 02:56:33 Re: dmetaphone woes