| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Date: | 2010-03-30 16:28:28 |
| Message-ID: | 4BB226AC.4020205@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-docs pgsql-hackers |
Fujii Masao wrote:
>> * Small code changes to handling of failedSources, inspired by your
>> comment. No change in functionality.
>>
>> This is also available in my git repository at
>> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges"
>
> I looked the patch and was not able to find any big problems until now.
> The attached small patch fixes the typo.
Thanks. Committed with that typo-fix, and I also added a comment
explaining how failedSources and retrying XLogPageRead() works.
I'm now happy with the standby mode logic. It was a bigger struggle than
I anticipated back in January/February, I hope others now find it
intuitive as well. I'm going to work on the documentation of this, along
the lines of the draft I posted last week.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-03-30 21:58:11 | pgsql: Fix "constraint_exclusion = partition" logic so that it will also |
| Previous Message | Heikki Linnakangas | 2010-03-30 16:23:57 | pgsql: Change the retry-loop in standby mode to also try restoring files |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2010-03-31 02:01:40 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Previous Message | Fujii Masao | 2010-03-30 08:52:19 | Streaming replication document improvements |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2010-03-30 16:42:41 | Re: OK for ABI break of PlannerInfo in 8.4? |
| Previous Message | Tom Lane | 2010-03-30 15:31:25 | OK for ABI break of PlannerInfo in 8.4? |