Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.
Date: 2010-02-24 06:30:27
Message-ID: 4B84C783.2090408@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Simon Riggs wrote:
> On Mon, 2010-02-22 at 11:47 +0000, Heikki Linnakangas wrote:
>> Log Message:
>> -----------
>> Move documentation of all recovery.conf option to a new chapter.
>> They used to be scattered between the "backup and restore" and "streaming
>> replication" chapters.
>
> It's just taken me 15 minutes to locate the settings for
> primary_conninfo to better understand Stefan's recent post.
>
> The commit referred to here is an extremely bad change.
>
> If you intended this to be a heading within the "High Availability"
> chapter then I would agree. This is what I thought you had done.

The idea was to have one chapter that describes all the options in
recovery.conf. Some of them are specific to streaming replication
(primary_conninfo), some are specific to PITR (recovery_target_*), some
are common (restore_command, restore_end_command). We need a reference
page to list them all.

> Having Streaming Rep described in HA and then describing the parameters
> that make it work in a separate chapter is ridiculous. Plus, wherever
> they are, they need cross references between them.

Yeah, there needs to be cross references. And the streaming rep docs
need to describe how to set the relevant settings, with examples.

> SR is a big feature and deserves proper docs.

Agreed.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2010-02-24 07:11:34 Re: pgsql: Un-break pg_dump for the case of zero-column tables.
Previous Message Takahiro Itagaki 2010-02-24 05:20:49 pgsql: Remove useless codes to initialize TupleDesc from dblink_exec.

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2010-02-24 06:52:06 Re: Issues for named/mixed function notation patch
Previous Message Josh Berkus 2010-02-24 05:37:27 Alpha4 Available Now