| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: updateMinRecoveryPoint bug? |
| Date: | 2009-12-30 08:37:39 |
| Message-ID: | 4B3B1153.50601@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Mon, 2009-12-28 at 14:40 +0200, Heikki Linnakangas wrote:
>> Fujii Masao wrote:
>
>>> How about always resetting ControlFile->minRecoveryPoint to {0, 0} at the
>>> beginning of a crash recovery, to fix the bug?
>> Yeah, that would work. I think it would be better to clear it in
>> CreateCheckPoint(), though, when we set the pointer to the new
>> checkpoint. That includes the shutdown checkpoint created at the end of
>> archive recovery. minRecoveryPoint should never be set during normal
>> operation, after all.
>
> Sounds better.
Committed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tarun Sharma | 2009-12-30 09:23:49 | solution to make static changes in pg_hba.conf file? |
| Previous Message | Robert Haas | 2009-12-30 06:55:26 | Re: KNNGiST for knn-search (WIP) |