Skip site navigation (1) Skip section navigation (2)

Re: Ticket 119: handling opclass in dlgIndex

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Ticket 119: handling opclass in dlgIndex
Date: 2009-12-27 10:09:03
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
Le 23/12/2009 20:04, Dave Page a écrit :
> On Wed, Dec 23, 2009 at 6:08 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> I don't really know what the english standard way of casing words is. I
>> know that, in French, you're supposed to put the first character of a
>> string in uppercase. In English, I suppose I need to put the first
>> character of each word in uppercase. So, I think we need to upper case
>> the n in "Column name" (ie, "Column Name"). Can you confirm?
> Sorry - I meant to explain more but was multi-tasking and messed up :-(

No problem :)

> In grammatically correct English, only the first word of a sentence
> should be capitalised, but looking at other software like XCode and
> Firefox, it seems it's not that simple. In fact, as I'm trying to
> write this, I'm struggling to see a pattern in either of those apps -
> for example, in XCode's preferences pane I see options like:
> Automatically Suggest
> Suggestion delay
> Default File Encoding
> Tab indents
> So, I think we should use English rules, and only capitalise the first
> word, *except* for following words which have special meaning because
> they are SQL keywords for example, or acronyms.

OK. I've done that on the dlgIndex source (.cpp and .xrc files). We need
to do this on the complete source.

New patch attached.

>> Will do. Should it be in another patch?
> Probably better, if only to keep the commit logs focused on one change.

OK. I'll do in another patch, but I would like to commit this one before.

>> Or we have to tell them we need to drop and create their index when they
>> click the OK button, perhaps giving them the choice to do it
>> concurrently. I wonder if there are other objects that would need that
>> treatment.
> I can't say I'm that excited about that. It's probably safer for them
> to create the new index manually and then drop the old. I suppose we
> could create, drop, rename, but there's still something about the idea
> that gives me the heebie-jeebies.

OK, not really a big issue anyways.


Attachment: ticket119_v2.patch
Description: text/x-patch (8.3 KB)

In response to

pgadmin-hackers by date

Next:From: Mariano ReingartDate: 2009-12-27 16:52:24
Subject: Re: Spanish (es_ES) translation
Previous:From: Guillaume LelargeDate: 2009-12-27 09:42:00
Subject: Re: Maintenance window review

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group