Re: LIKE INCLUDING COMMENTS code is a flight of fancy

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: LIKE INCLUDING COMMENTS code is a flight of fancy
Date: 2009-12-22 20:47:33
Message-ID: 4B313065.3050309@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
>
> I'm for forbidding comments on index columns. The amount of work
> required to support the feature fully seems far out of proportion to
> its value.
>
> In any case, if pg_dump drops such comments (which I had forgotten,
> but it seems true after a quick look at the code), then we could
> certainly get away with having LIKE not copy them. That would fix
> the immediate problem.
>
>
>

If we're going to keep the comments we should dump them. I don't mind
dropping them altogether - it's hardly a killer feature. We should just
be consistent, IMNSHO.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-22 20:47:38 Re: Tuplestore should remember the memory context it's created in
Previous Message Heikki Linnakangas 2009-12-22 20:47:14 Re: Backup history file should be replicated in Streaming Replication?