fdw validation function vs zero catalog id

From: Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: fdw validation function vs zero catalog id
Date: 2009-12-20 13:39:10
Message-ID: 4B2E28FE.3040800@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

It appears that the function for validating generic options to a FDW,
SERVER and USER MAPPING is always passed a catalog oid of 0. Whereas
it should actually be passed the oid of the catalog that the options
apply to.

Attached patch fixes the issue by passing the proper catalog id from
transformGenericOptions().

PS. I personally would like this applied to 8.4 as well -- it'd enable
us to write a proper validator for pl/proxy fdw.

regards,
Martin

Attachment Content-Type Size
fdw-validator.patch text/x-diff 9.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2009-12-20 15:15:39 Re: Aggregate ORDER BY patch
Previous Message James William Pye 2009-12-20 10:07:22 Re: alpha3 bundled -- please verify