Re: tsearch parser inefficiency if text includes urls or emails - new version

From: Greg Smith <greg(at)2ndquadrant(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, oleg(at)sai(dot)msu(dot)su, teodor(at)sigaev(dot)ru
Subject: Re: tsearch parser inefficiency if text includes urls or emails - new version
Date: 2009-12-08 19:09:22
Message-ID: 4B1EA462.40307@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner wrote:
> After running a series of tests with --enable-cassert to confirm
> that nothing squawked, I disabled that before doing any
> performance testing. Going from memory, I used --enable-debug
> --with-libxml and --prefix. I didn't explicitly use or disable any
> compiler optimizations.
>
> Possibly relevant is that I was using Greg Smith's peg tool (as best
> I could):
>
> http://github.com/gregs1104/peg/
>
> I'm not aware of it doing anything to the compile options, but I
> didn't look for that, either.
Now that you ask, of course I just spotted a bug in there such that the
documented behavior for the PGDEBUG feature doesn't actually work. If
you were using that to turn off asserts, that may not have worked as
expected. Don't know what you did there exactly. Fix now pushed to the
repo.

I general, when doing performance testing, now matter how careful I've
been I try to do a:

show debug_assertions;

To confirm I'm not running with those on.

Andres, are using any optimization flags when you're testing?

Would have preferred that the first mention of my new project didn't
involve a bug report, but that's software I guess. For everyone here
who's not on the reviewers mailing list: peg is a scripting tool I've
put together recently that makes it easier to setup the environment
(source code, binaries, database) for testing PostgreSQL in a
development content. It takes care of grabbing the latest source,
building, starting the database, all that boring stuff. I tried to make
it automate the most tedious parts of both development and patch
review. Documentation and the program itself are at the git repo Kevin
mentioned.

--
Greg Smith 2ndQuadrant Baltimore, MD
PostgreSQL Training, Services and Support
greg(at)2ndQuadrant(dot)com www.2ndQuadrant.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2009-12-08 19:16:55 More broken links in documentation
Previous Message Tom Lane 2009-12-08 18:50:53 Re: Adding support for SE-Linux security