Re: Why do OLD and NEW have special internal names?

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Why do OLD and NEW have special internal names?
Date: 2009-11-08 17:32:44
Message-ID: 4AF700BC.3060507@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom,

> BTW, this brings up another point, which is that up to now it's often
> been possible to use plpgsql variable names that conflict with
> core-parser reserved words, so long as you didn't need to use the
> reserved word with its special meaning. That will stop working when
> this patch goes in. Doesn't bother me any, but if anyone thinks it's
> a serious problem, speak now.

Sounds like a potential *big* blocker to upgrading; anyone with several
thousand lines of plpgsql can't really afford to refactor away all of
the accidental uses of reserved words.

That being said, reusing reserved words in this way was always wonky, so
I'm not sure how many people will have done so. Best way is to commit
it to alpha3, and try to get people to test.

--Josh Berkus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2009-11-08 21:17:47 Re: Typed tables
Previous Message Kenneth Marshall 2009-11-08 16:41:15 Re: [PATCH] tsearch parser inefficiency if text includes urls or emails - new version