Re: WIP: push AFTER-trigger execution into ModifyTable node

From: Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP: push AFTER-trigger execution into ModifyTable node
Date: 2009-11-01 15:22:03
Message-ID: 4AEDA79B.8050508@cs.helsinki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> However, this still doesn't address the problem of what happens when the
> top-level select fails to read all of the CTE output (because it has a
> LIMIT, or the client doesn't read all the output of a portal, etc etc).
> Partially executing an update in such cases is no good.

I've previously thought about making the CTE aware of the LIMIT,
similarly to a top-N sort, but I don't think it's worth it. If we have
a LIMIT, we could just fall back to the statement-at-the-time execution.
I'm not sure what all cases you mean with "the client doesn't read all
the output of a portal", but at least for cursors we'd have to first
execute ModifyTable nodes.

Regards,
Marko Tiikkaja

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-01 15:40:49 Re: WIP: push AFTER-trigger execution into ModifyTable node
Previous Message Andres Freund 2009-11-01 15:19:43 [PATCH] tsearch parser inefficiency if text includes urls or emails