| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, "Turner, Ian" <Ian(dot)Turner(at)deshaw(dot)com>, pgsql-bugs(at)postgresql(dot)org, "Silverman, Richard" <res(at)deshaw(dot)com> |
| Subject: | Re: Kerberos authentication, Active Directory, and PostgreSQL |
| Date: | 2009-10-14 13:09:12 |
| Message-ID: | 4AD5CD78.8070307@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> A small wish in case we go with this: The constant should be named
>> something like PG_...; otherwise it looks like we are defining or
>> overriding an official symbol from the GSS API.
>
> I'd be inclined to just s/2000/32767/ and not bother with a symbol,
> misleadingly named or otherwise. If the value were actually being
> used in more than one place, it'd be a different story, but to be
> so used it would likely need a completely different name.
It is used in two places in that file: pg_GSS_recvauth() and
pg_SSPI_recvauth(). (the original patch neglected SSPI)
I'll rename it to PG_MAX_AUTH_TOKEN_LENGTH, unless someone has a better
suggestion.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | flamindragon1 | 2009-10-14 13:56:02 | BUG #5114: database initialization |
| Previous Message | Heikki Linnakangas | 2009-10-14 07:28:29 | Re: Kerberos authentication, Active Directory, and PostgreSQL |