From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Hot Standby 0.2.1 |
Date: | 2009-10-08 03:11:46 |
Message-ID: | 4ACD5872.8000503@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Simon Riggs wrote:
> On Tue, 2009-09-22 at 12:53 +0300, Heikki Linnakangas wrote:
>> It looks like the standby tries to remove XID 4323 from the
>> known-assigned hash table, but it's not there because it was removed
>> and set in pg_subtrans by an XLOG_XACT_ASSIGNMENT record earlier. I
>> guess we should just not throw an error in that case, but is there a
>> way we could catch that narrow case and still keep the check in
>> KnownAssignedXidsRemove()? It seems like the check might help catch
>> other bugs, so I'd rather keep it if possible.
>
> Fix attached.
I fixed that on Friday already, in a slightly different manner. Do you
see a problem with that approach?
I've made public the version I'm working on. That's the version I'm
ultimately going to commit. It would be a lot more helpful if you
provided these patches over that version. Otherwise I have to refactor
them over that codebase, possibly introducing new bugs.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2009-10-08 03:19:46 | Re: Hot Standby 0.2.1 |
Previous Message | u235sentinel | 2009-10-08 03:09:26 | Re: postgres 8.3.8 and Solaris 10_x86 64 bit problems? |