| From: | Emmanuel Cecchet <manu(at)frogthinker(dot)org> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Emmanuel Cecchet <manu(at)asterdata(dot)com>, Selena Deckelmann <selenamarie(at)gmail(dot)com>, Emmanuel Cecchet <Emmanuel(dot)Cecchet(at)asterdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: COPY enhancements |
| Date: | 2009-10-07 02:07:31 |
| Message-ID: | 4ACBF7E3.3090306@frogthinker.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I just realized that I forgot to CC the list when I answered to Josh... resending!
Josh,
>> >> I think that this was the original idea but we should probably rollback
>> >> the error logging if the command has been rolled back. It might be more
>> >> consistent to use the same hi_options as the copy command. Any idea what
>> >> would be best?
>> >>
>>
> >
> > Well, if we're logging to a file, you wouldn't be *able* to roll them
> > back. Also, presumbly, if you abort a COPY because of errors, you
> > probably want to keep the errors around for later analysis. No?
> >
>
You are right about the file (though this functionality is not
implemented yet).
I don't have any strong opinion about the right behavior if COPY aborts.
The error log table would contain tuples that were not inserted anyway.
Now knowing whether the bad tuples come from a successful COPY command
or not will be left to the user.
Emmanuel
-- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2009-10-07 02:28:08 | Re: Encoding issues in console and eventlog on win32 |
| Previous Message | KaiGai Kohei | 2009-10-07 01:45:48 | Re: [PATCH] DefaultACLs |