Re: We should Axe /contrib/start-scripts

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Josh Berkus" <josh(at)agliodbs(dot)com>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Chander Ganesan" <chander(at)otg-nc(dot)com>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: We should Axe /contrib/start-scripts
Date: 2009-08-26 15:23:06
Message-ID: 4A950D0A020000250002A26A@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> start_daemon doesn't provide for switching to a non-root userid
> according to that spec, so it seems like *it's* missing a crucial
> detail.

Hmmm... I didn't see anything requiring that it only by run by root.
Do you see something that suggests that it must be?

I've been making my attempts as the owner of the cluster, assuming
that the init script would su to that before calling that function.

> it's unclear if killproc is supposed to wait to see whether the
> daemon terminates.

I think it's pretty clear, in the context of the whole spec, that it
should give it *some* time to make the attempt, since it says that it
should return zero if the daemon was successfully terminated and
non-zero otherwise. I think that also suggests that it doesn't expect
you to wait forever. You do kinda have to read between the lines and
take the spec from a "holistic" perspective, I'll grant you that....

-Kevin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2009-08-26 15:37:10 Re: 8.5 release timetable, again
Previous Message Jean-Michel Pouré 2009-08-26 15:18:07 Re: 8.5 release timetable, again