| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Greg Stark <gsstark(at)mit(dot)edu> |
| Cc: | Roger Leigh <rleigh(at)codelibre(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Roger Leigh <rleigh(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Unicode UTF-8 table formatting for psql text output |
| Date: | 2009-08-23 03:20:08 |
| Message-ID: | 4A90B568.7070806@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Stark wrote:
> I don't really have an opinion between one big patch versus multiple
> smaller patches. That will come down to the code and whether the
> separate patches are easier to read. It is sometimes hard to review a
> patch when its separated from the code which needs the new
> functionality though.
>
>
>
I have an opinion. These patches involved multiple changes to the same
few files.
Please, don't do that.
In general one patch per feature is what makes life for reviewers and
committers easier. For big features, sometimes we ask people to break it
up into several patches, but this wasn't a big feature at all, and there
is not the slightest need for more than one patch.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-08-23 03:20:40 | Re: BUG #4996: postgres.exe memory consumption keeps going up |
| Previous Message | Greg Stark | 2009-08-23 02:56:20 | Re: Unicode UTF-8 table formatting for psql text output |