| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Bernd Helmle <mailings(at)oopsware(dot)de> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: conditional dropping of columns/constraints |
| Date: | 2009-07-20 02:46:43 |
| Message-ID: | 4A63DA93.9080201@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bernd Helmle wrote:
>
> Here is a slightly updated version of the patch. I did some (very
> minor) editing on the wording in the docs and cleaned a merge conflict
> in tablecmds.c. I saw no code issues so far, make check passes without
> errors. Maybe someone with more bison skills can comment on the
> duplicated parser stuff, but it seems consistent with the rest of the
> code.
The duplicated stuff in the grammar is pretty much what had to be done
for other DROP IF EXISTS items to avoid shift/reduce conflicts, so it's
quite kosher.
patch committed.
Thanks.
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-20 02:56:52 | Re: join removal |
| Previous Message | Alvaro Herrera | 2009-07-20 02:39:51 | Re: WIP: Deferrable unique constraints |