| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Move some declarations in the raw-parser header files to create a |
| Date: | 2009-07-13 00:05:27 |
| Message-ID: | 4A5A7A47.2030105@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Tom Lane wrote:
> Log Message:
> -----------
> Move some declarations in the raw-parser header files to create a clearer
> distinction between the external API (parser.h) and declarations that only
> need to be visible within the raw parser code (gramparse.h, which now is only
> included by parser.c, gram.y, scan.l, and keywords.c). This is in preparation
> for the upcoming change to a reentrant lexer, which will require referencing
> YYSTYPE in the declarations of base_yylex and filtered_base_yylex, hence
> gram.h will have to be included by gramparse.h. We don't want any more files
> than absolutely necessary to depend on gram.h, so some cleanup is called for.
>
Seems to have broken MSVC:
src\pl\plpgsql\src\scan.l(46): error C2370: 'standard_conforming_strings' : redefinition; different storage class
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-07-13 00:33:43 | Re: pgsql: Move some declarations in the raw-parser header files to create a |
| Previous Message | Tom Lane | 2009-07-12 17:12:34 | pgsql: Move some declarations in the raw-parser header files to create a |