Re: BUG #4879: bgwriter fails to fsync the file in recovery mode

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Date: 2009-06-25 21:37:38
Message-ID: 4A43EE22.90408@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Simon Riggs wrote:
> On Thu, 2009-06-25 at 15:10 -0400, Tom Lane wrote:
>
>> So to summarize the state of play, it seems
>> we have these issues:
>>
>> * need to delete startup process's local pendingOpsTable once bgwriter
>> is launched, so that requests go to bgwriter instead
>
> Need to ensure that fsync requests are directed to the process that will
> act on the fsync requests.
>
>> * need to push end-of-recovery checkpoint into bgwriter
>
> That's probably the easiest thing to do, but the issue is that we must
> fsync all files mentioned in the pendingOpsTable in *any* process that
> has been accumulating such requests.
>
>> * need to do something about IsRecovery tests that will now be executed
>> in bgwriter
>
> Yes
>
>> * need to fix mistaken code in FinishPreparedTransaction
>
> Yes

Ok, I've committed the above fixes everyone agreed on.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Simon Riggs 2009-06-25 21:39:21 Re: BUG #4879: bgwriter fails to fsync the file in recovery mode
Previous Message Peter Eisentraut 2009-06-25 21:29:54 Re: BUG #4883: tar xf fails on NFS4 mounts