Re: pgindent run coming

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run coming
Date: 2009-06-10 19:13:05
Message-ID: 4A3005C1.7070700@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
> I did a diff, attached, and found some typedefs that don't appear, like
> PortalData. That is defined in our code as:
>
> typedef struct PortalData *Portal;
>
> typedef struct PortalData
> {
> /* Bookkeeping data */
> ...
> bool visible; /* include this portal in pg_cursors? */
> } PortalData;
>
> I will try to build on Linux here and see how objdump displays that,
> unless you can get me the output.
>

Well, that is almost certainly a result of the change you asked me to
make :-)

The symbol is in the run done early this morning before those changes.
See
<http://www.pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=dungbeetle&dt=2009-06-10%20064401&stg=typedefs>

So we need to look and see what tag that symbol has in the objdump output.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-06-10 19:15:36 Re: Resolving 8.4 open items
Previous Message Greg Stark 2009-06-10 19:10:46 Re: pgindent run coming