Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Kenneth Marshall <ktm(at)rice(dot)edu>, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)
Date: 2009-05-25 17:58:59
Message-ID: 4A1ADC63.9070004@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/25/2009 07:53 PM, Andres Freund wrote:
> On 05/25/2009 07:31 PM, Tom Lane wrote:
>> David Fetter<david(at)fetter(dot)org> writes:
>>> On Mon, May 25, 2009 at 12:24:05PM -0400, Tom Lane wrote:
>>>> If you'd like to accomplish something *useful* about this, how about
>>>> pestering git upstream to support diff -c output format?
>>
>>> It looks like this is doable with a suitable git configuration file
>>> such as $HOME/.gitconfig or (finer grain) a .git/config for the
>>> repository :)
>>
>> Cool, let's see one.
>>
>> If we were to put it into a repository config file, that would more or
>> less have the effect of enforcing a project style for diffs, no?
> Yes and no.
>
> You can define that a subset (or all) files use a specific "diff driver"
> in the repository - unfortunately the definition of that driver has to
> be done locally. Defining it currently involves installing a wrapper
> like the one on http://wiki.postgresql.org/wiki/Talk:Working_with_Git
> and doing
Ugh, hit the wrong key:
and executing
`git config --global diff.context.command "git-external-diff"`

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-05-25 18:02:54 Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)
Previous Message Andres Freund 2009-05-25 17:53:20 Re: [PATCH] cleanup hashindex for pg_migrator hashindex compat mode (for 8.4)