Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To:
Cc: pgsql-www(at)postgreSQL(dot)org
Subject: Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)
Date: 2009-05-16 11:03:26
Message-ID: 4A0E9D7E.9050805@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-www

Alvaro Herrera wrote:
> Alvaro Herrera wrote:
>> Tom Lane wrote:
>>> Log Message:
>>> -----------
>>> Fix all the server-side SIGQUIT handlers (grumble ... why so many identical
>>> copies?) to ensure they really don't run proc_exit/shmem_exit callbacks,
>>> as was intended. I broke this behavior recently by installing atexit
>>> callbacks without thinking about the one case where we truly don't want
>>> to run those callback functions. Noted in an example from Dave Page.
>> Something seems wrong on the GIT mirror. This patch appears as
>> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e5a8ea96adf14b9d822aff82d8f4ebf41d3a8e95
>> however, it only shows the diff for xlog.c, not the other files that
>> were touched by this commit.
>
> So I foolishly assumed that it would fix itself when the next sync
> occured, but several hours have passed and the problem still exists.
>

I tried to figure something out about this, but I have no clue.

The rsync:ed copy of the cvs repository that the conversion runs at has
all the changes.

The git repository has only the xlog.c one (checked in the server repo
as well just to be sure it wasn't anything in the gitweb install or
anything)

The ruby magic ("fromcvs") that does the importing says nothing - it
runs without any complaints and says there is nothing to do.

Any ideas at all where to look?

I wonder if the many identical copies somehow broke the import script or
something...

//Magnus

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2009-05-16 11:51:59 Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)
Previous Message Alvaro Herrera 2009-05-15 22:17:01 Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2009-05-16 11:51:59 Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)
Previous Message Alvaro Herrera 2009-05-15 22:17:01 Re: Problem in GIT mirror (was Re: pgsql: Fix all the server-side SIGQUIT handlers ...)