Re: conditional dropping of columns/constraints

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: conditional dropping of columns/constraints
Date: 2009-05-07 10:57:56
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Tom, hi all,

On 05/06/2009 11:43 PM, Tom Lane wrote:
> Andres Freund<andres(at)anarazel(dot)de> writes:
>> As this is my first patch to PG I am happy with most sort of feedback.
> Please add your patch to the commit-fest queue here:
Will do so, after this email has arrived.

> Since we are still busy with 8.4 beta, it's unlikely that anyone will
> take a close look until the next commit fest begins. FWIW, I took a
> very fast look through the patch and thought it was at least touching
> the right places, except I think you missed equalfuncs.c. (It'd be a
> good idea to grep for all uses of AlterTableCmd struct to see if you
> missed anything else.) I don't have time now to look closer or do any
> testing.
Ok, fixed that place (stupid me, I had seen that it is used there and
forgot about it) and found no other places.



Attachment Content-Type Size
0001-Feature-DROP-COLUMN-CONSTRAINT-IF-EXISTS.patch text/x-diff 0 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-05-07 11:33:16 Re: ECPG, two varchars with same name on same line
Previous Message Gregory Stark 2009-05-07 10:34:16 Re: Serializable Isolation without blocking