Re: BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: henry_boehlert(at)agilent(dot)com, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode
Date: 2017-07-14 13:07:46
Message-ID: 49d09912-6ad5-ddac-24a7-e7d4b8139a3e@iki.fi
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-bugs pgsql-hackers

On 07/14/2017 05:27 AM, Haribabu Kommi wrote:
> On Fri, Jul 14, 2017 at 2:54 AM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
>> On 05/03/2017 07:32 AM, Haribabu Kommi wrote:
>>
>>> [Adding -hackers mailing list]
>>>
>>> On Fri, Apr 28, 2017 at 6:28 PM, <henry_boehlert(at)agilent(dot)com> wrote:
>>>
>>>> Executing command pg_basebackup -D -F t writes its output to stdout,
>>>> which
>>>> is open in text mode, causing LF to be converted to CR LF thus corrupting
>>>> the resulting archive.
>>>>
>>>> To write the tar to stdout, on Windows stdout's mode should be
>>>> temporarily
>>>> switched to binary.
>>>>
>>>> https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx
>>>
>>> Thanks for reporting the issue.
>>> With the attached patch, I was able to extract the tar file that gets
>>> generated when the tar file is written into stdout. I tested the
>>> the compressed tar also.
>>>
>>> This bug needs to be fixed in back branches also.
>>
>> Seems reasonable. One question:
>>
>> In the patch, you used "_setmode" function, while the calls in
>> src/bin/pg_dump/pg_backup_archiver.c use "setmode". There are a few
>> places in the backend that also use "_setmode". What's the difference?
>> Should we change some of them to be consistent?
>
> Actually there is no functional difference between these two functions.
> one is a POSIX variant and another one is ISO C++ variant [1]. The support
> of POSIX variant is deprecated in windows, because of this reason we should
> use the _setmode instead of setmode.
>
> I attached the patch to change the pg_dump code to use _setmode function
> instead of _setmode to be consistent with other functions.

Ok, committed and backpatched both patches. Thanks!

- Heikki

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2017-07-14 14:22:07 Re: BUG #14742: build fails on psql
Previous Message chris 2017-07-14 12:51:06 BUG #14742: build fails on psql

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2017-07-14 13:35:56 Re: Pluggable storage
Previous Message Alik Khilazhev 2017-07-14 13:04:28 Re: [WIP] Zipfian distribution in pgbench