Re: Re: csv format for psql

From: David Steele <david(at)pgmasters(dot)net>
To: Daniel Verite <daniel(at)manitou-mail(dot)org>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: csv format for psql
Date: 2018-03-21 17:27:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Daniel,

On 3/10/18 1:49 AM, Fabien COELHO wrote:
>>> recordsep in the unaligned mode doesn't play the role of a line ending
>>> because the last line is not finished by recordsep. According to the
>>> source
>>> code, this is intended, see print_unaligned_text() in print.c:
>> Something else comes to mind: CSV allows linefeeds inside fields, and
>> we don't want to replace these with record separators.
> Sure.
>> So the notion that recordsep can be used to choose line endings
>> is even less okay than if there was just the last line issue.
> I'm not following. ISTM that the escaping macanism would work in pretty
> all reasonable cases, although it might be possible to shot oneself in
> the foot by setting manually strange values for recordsep, eg '"'. I do
> not see that as a significant issue. If the user asks for something
> stupid, they get something stupid, fine.

This patch looks like it is getting close but there has been no update
in a while.

Do you know when you'll have an updated patch that addresses the minor
issues brought up in review and the concern above?


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2018-03-21 17:30:08 Re: [HACKERS] Secondary index access optimizations
Previous Message Alvaro Herrera 2018-03-21 17:07:04 Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT