From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
---|---|
To: | Chuck McDevitt <cmcdevitt(at)greenplum(dot)com> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Solaris getopt_long and PostgreSQL |
Date: | 2009-03-17 16:50:05 |
Message-ID: | 49BFD4BD.7030008@sun.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dne 17.03.09 17:24, Zdenek Kotala napsal(a):
> Dne 17.03.09 17:13, Zdenek Kotala napsal(a):
>
>>> I don’t know if I should revert that change, or port netBSD
>>> getopt_long and replace the PostgreSQL one with that.
>>
>> getopt_long is OK. Problem is getopt. getopt in core is currently
>> taken from *BSD but it could be updated.
>>
>> One possible solution should be to use internal getopt only for
>> postgres binary and for other to use solaris libc version.
>
> I'm now looking into the code and most binaries uses getopt_long which
> works fine. I think getopt_long can be used from Solaris libc. Only
> postgres and pg_resetxlog uses getopt. I think nobody has problem with
> postgres, because it is called from pg_ctl or other start/stop script
> and pg_resetxlog should be modified to use getopt_long.
>
There is a patch, please test it if it satisfy your expectation. Do not
forget run autoconf.
Zdenek
Attachment | Content-Type | Size |
---|---|---|
getopt.patch | text/plain | 407 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-03-17 16:54:08 | Re: Problem with zero year |
Previous Message | Joshua D. Drake | 2009-03-17 16:43:35 | Re: Ignore -- testing message-id on footer |