| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | jd(at)commandprompt(dot)com, Greg Sabino Mullane <greg(at)endpoint(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: One less footgun: deprecating pg_dump -d |
| Date: | 2009-03-09 19:12:39 |
| Message-ID: | 49B56A27.6010304@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
>> Sorry Tom. Greg is correct here although I disagree with his wording. It
>> should be removed and if someone passes -d it should throw an ERROR that
>> says something like:
>> ERROR: -d has been replaced by -I
>
> Well, if you want to break it, we can debate about the wisdom of that.
> But please don't describe the patch in such a misleading way as the
> current thread title.
+1 with breaking it, but with a better message (and let's call it
breaking, not deprecating).
Oh, and the patch contains what looks like two merge failures, I'm sure
that wasn't intentional...
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron Mayer | 2009-03-09 19:14:34 | Re: One less footgun: deprecating pg_dump -d |
| Previous Message | Robert Haas | 2009-03-09 19:00:46 | Re: Updates of SE-PostgreSQL 8.4devel patches (r1704) |