Re: pg_hba.conf - patch to report all parsing errors, and then bail

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Selena Deckelmann <selena(at)endpoint(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_hba.conf - patch to report all parsing errors, and then bail
Date: 2009-03-07 21:28:10
Message-ID: 49B2E6EA.1090402@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Tom Lane wrote:
>>> It sure looks like that's going to try to free new_parsed_lines more
>>> than once. Shouldn't clean_hba_list be done just once?
>
>> Yeah, it should be done in the if branch down below. And I think by our
>> coding standards (or at least by our conventions), the variable should
>> be "ok" and not "OK".
>
>> Unless there are any objections, I can do those cleanups and apply it.
>
> I thought the adjacent comments could do with a bit more wordsmithing,
> also, but otherwise that about covers it.

Applied.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-03-07 21:53:55 Re: Out parameters handling
Previous Message Alvaro Herrera 2009-03-07 19:38:34 Re: [COMMITTERS] pgsql: Avoid MSVC breakage caused by my previous commit by not using a