Re: Server Status window work

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Server Status window work
Date: 2009-02-24 18:53:18
Message-ID: 49A4421E.9040604@lelarge.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Dave Page a écrit :
> On Wed, Feb 18, 2009 at 11:02 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>
>> Done. It was much harder than I initially thought but I really like this
>> one. I checked on each platform and it behaves nicely on each.
>
> Yeah, that looks much nicer. I tried it on Windows and Mac, and came
> across the following issues. Note that I've attached a couple of
> screenshots of the default layouts (ie. having removed all frmStatus
> related settings from the ini file/registry):
>
> - The Refresh rate combo box is top-justified on Mac. Why is it on a
> separate toolbar though?
>

I just copied and pasted the frmQuery example :)

The new patch uses only one toolbar. The combobox is no more
top-justified on Mac.

> - The terminate backend button icon should at least be a different
> colour from the cancel button.
>

Hmmm, I'm not really good at drawing. Anyway, I added some red in it.

> - If I undock a pane on Mac, the default size is about 2 pixels wide
> by 20 high (thats a guess). Makes it pretty hard to see or resize :-p
>

I'm a bit lost here. I have some issues on Mac, but I don't know how to
delete saved preferences. On GTK, it's simple. I just need to edit the
~/.pgadmin3 file. On Windows, it's a bit more difficult but with
regedit, one can do it. But I don't find a way to do this on Mac. Can
you shared your precious knowledge ? :)

> - If I set a different refresh time for each pane, I would expect to
> see the value change in the combo box when I select different panes.
>

Well, it should. And it does when you click on another line than the one
already selected. EVT_LIST_ITEM_SELECTED doesn't get fired when the user
clicks on the already selected row. And I don't find another "activate"
event. Do you one that I can use ?

> - Should we use wxAUI_MGR_ALLOW_ACTIVE_PANE when we setup the manager?
> That will display the title bar of the active pane in a different
> colour, but it's not entirely tied to whether or not the listview is
> active or not. You can see this in the Mac screenshot.
>

Done.

> - The timer defaults should probably be more like 10 seconds than 1.
>

Fixed.

> - There should be a view option for the toolbar.
>

Done too.

> - The default layout does not work with the default size. See the screenshots.
>

I changed them. Hope it will work better.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Attachment Content-Type Size
serverstatus_p1_v13.patch.bz2 application/x-bzip 11.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2009-02-24 19:18:24 SVN Commit by guillaume: r7611 - in trunk/pgadmin3/i18n: af_ZA ar_SA bg_BG ca_ES cs_CZ da_DK de_CH de_DE el_GR es_ES fa_IR fi_FI fr_FR gl_ES gu_IN hi_IN hr_HR hu_HU id_ID is_IS it_IT ja_JP ko_KR lt_LT lv_LV mk_MK nb_NO nl_NL pl_PL pt_BR pt_PT ro_RO ru_RU sk_SK sl_SI sr_YU sv_SE te_IN tl_PH tr_TR uk_UA ur_PK vi_VN zh_CN zh_TW
Previous Message svn 2009-02-24 17:49:22 SVN Commit by dpage: r7610 - in trunk/pgadmin3/pgadmin: dlg frm include/schema schema