Re: Latest on CITEXT 2.0

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, "Martijn van Oosterhout" <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Latest on CITEXT 2.0
Date: 2008-07-01 14:52:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Marko Kreen" <markokr(at)gmail(dot)com> writes:
> On 6/26/08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> BTW, I don't think you can use that same-length optimization for
>> citext. There's no reason to think that upper/lowercase pairs will
>> have the same length all the time in multibyte encodings.

> What about this code in current str_tolower():

> /* Output workspace cannot have more codes than input bytes */
> workspace = (wchar_t *) palloc((nbytes + 1) * sizeof(wchar_t));

That's working with wchars, not bytes.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Radek Strnad 2008-07-01 14:58:36 [WIP] patch - Collation at database level
Previous Message Marko Kreen 2008-07-01 14:50:43 Re: Latest on CITEXT 2.0