Re: pgAgent: Log connection error message and initial connection

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAgent: Log connection error message and initial connection
Date: 2009-02-06 14:33:34
Message-ID: 498C4A3E.1040906@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,
>> - If the initial connection attempt fails, it will loop, and
>> retry a few times at the speed of the normal timing loop
>> before giving up.
>
> Hmm, I don't see any of the service code I expected to see for
> Windows. At the moment when the service starts we start MainLoop() and
> immediately tell the SCM that the service state is 'running'. What we
> should do, is tell the SCM that the service is starting until the
> primary connection is successful, and only then tell the SCM that
> we're running. That way, the service will refuse to start if the
> connection cannot be made, rather than starting and then stopping
> again. It'll also mean that when starting the service manually, the
> progress bar will be shown until the connection is established and we
> know everything is good.
>
> That's the code I mentioned I'd worked on in pg_ctl - in particular
> look at the do_checkpoint related stuff in
> test_postmaster_connection() which is how we tell the SCM that we're
> still trying to startup.
Please find the updated patch for that.
--
Regards,
Ashesh Vashi

EnterpriseDB INDIA: http://www.enterprisedb.com

Attachment Content-Type Size
pgagent_logConnError_primaryConnAttempt_v2.patch text/x-diff 6.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message zhen shang 2009-02-06 16:33:00 Hello.I need help on PostgreSQL server log file encoding problem on Windows system! I appreciate any help on this problem I am facing and thank in advance.
Previous Message svn 2009-02-05 14:40:03 SVN Commit by dpage: r7582 - trunk/www/development