Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: David Christensen <david(at)endpoint(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line
Date: 2017-02-18 00:16:08
Message-ID: 49826b8a-e3ce-762e-95d2-8119ff872b00@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/15/17 10:40, David Christensen wrote:
> Throws a build error if we encounter a different number of fields in a
> DATA() line than we expect for the catalog in question.
>
> Previously, it was possible to silently ignore any mismatches at build
> time which could result in symbol undefined errors at link time. Now
> we stop and identify the infringing line as soon as we encounter it,
> which greatly speeds up the debugging process.

I think this would be useful. I haven't reviewed the code, but the
general idea looks reasonable.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-02-18 00:22:40 Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
Previous Message Peter Eisentraut 2017-02-18 00:10:56 Re: pg_basebackup -R