Re: Text search segmentation fault

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Grzegorz Jaśkiewicz <gryzman(at)gmail(dot)com>
Cc: General Postgres Mailing List <pgsql-general(at)postgresql(dot)org>
Subject: Re: Text search segmentation fault
Date: 2009-01-29 15:32:02
Message-ID: 4981CBF2.6030008@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

> Than I have quite few notes about that function:
> - affix is not checked on entry, and should be unsigned,

Could be Assert( affix>=0 && affix < Conf->nAffixData )

> - for sake of safety uint32_t should be used instead of unsigned int,
> in the cast
see patch
> - there should be some safety limit for lenght of str,
It's a C-string

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Grzegorz Jaśkiewicz 2009-01-29 15:34:59 Re: Text search segmentation fault
Previous Message Teodor Sigaev 2009-01-29 15:26:25 Re: Text search segmentation fault