Re: [PATCHES] Infrastructure changes for recovery

(replying to a very old message, since I just bumped into this in review)

Alvaro Herrera wrote:
> Simon Riggs wrote:
>> On Fri, 2008-09-12 at 14:14 -0400, Alvaro Herrera wrote:
>>> Simon Riggs wrote:
>>>
>>>> --- 5716,5725 ----
>>>> CheckpointStats.ckpt_sync_end_t,
>>>> &sync_secs, &sync_usecs);
>>>>
>>>> ! elog(LOG, "%s complete: wrote %d buffers (%.1f%%); "
>>>> "%d transaction log file(s) added, %d removed, %d recycled; "
>>>> "write=%ld.%03d s, sync=%ld.%03d s, total=%ld.%03d s",
>>>> + (checkpoint ? " checkpoint" : "restartpoint"),
>>>> CheckpointStats.ckpt_bufs_written,
>>>> (double) CheckpointStats.ckpt_bufs_written * 100 / NBuffers,
>>>> CheckpointStats.ckpt_segs_added,
>>> Very minor nit: this really needs a rework.
>> All I changed was the word "restartpoint"... its otherwise identical to
>> existing message. I'd rather not change that.
>
> The new message is not translatable, the original was.

Doesn't really matter since it's an elog(), not ereport().

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com