| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Compiler warnings fix |
| Date: | 2009-01-27 12:47:29 |
| Message-ID: | 497F0261.6030101@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
ITAGAKI Takahiro wrote:
> Here is a patch to surpress compiler warnings in pg_locale.c and pg_regress.c.
>
> There are following warnings if nls is enabled:
> pg_locale.c: In function `pg_perm_setlocale':
> pg_locale.c:161: warning: assignment discards qualifiers from pointer target type
> and if nls is disabled:
> pg_locale.c:615: warning: 'IsoLocaleName' defined but not used
>
> There is also a warning in pg_regress.c:
> pg_regress.c: In function `wait_for_tests':
> pg_regress.c:1367: warning: passing arg 2 of `GetExitCodeProcess' from incompatible pointer type
Applied (as two separate patches since I missed that there were two
files initially).
I agree with other comments that #ifdef:ing on LC_MESSAGES may not be
the greatest-looking solution, but the code that calls it is ifdef:ed
that way, so mimicking that seems like the right thing to do at this time.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2009-01-27 12:51:53 | Re: binary array and record recv |
| Previous Message | Magnus Hagander | 2009-01-27 12:46:16 | pgsql: Silence compiler warning on win32. |