Re: Patch to add Windows 7 support

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to add Windows 7 support
Date: 2009-01-27 11:04:35
Message-ID: 497EEA43.1000406@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dave Page wrote:
> The attached patch adds support for the Windows 7 beta which we've had
> a few reports of incompatibility with. When we startup using pg_ctl on
> Windows, we create a job object (a logical grouping of processes on
> Windows) to which we apply various security options. One of these
> (JOB_OBJECT_UILIMIT_HANDLES) is used to prevent our processes seeing
> handles belonging to processes outside of our job, however, when we
> run under the service control manager, this causes the postmaster to
> exit immeditately for no apparent reason.
>
> I'm not entirely sure what has change in the SCM to cause this yet
> (Windows 7 documentation is somewhat thin on the ground at the
> moment), but the patch avoids theporblem by only setting
> JOB_OBJECT_UILIMIT_HANDLES on earlier OSs.
>
> Tested on CVS head, but should probably be backpatched to 8.3 to avoid
> more bug reports.

No objections here, but seems we should revisit this after Windows 7 is
released, and revert if they've fixed the underlying problem during the
beta period.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2009-01-27 11:06:19 Re: Patch to add Windows 7 support
Previous Message Dave Page 2009-01-27 10:34:56 Patch to add Windows 7 support