| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hot standby, dropping a tablespace |
| Date: | 2009-01-25 17:56:38 |
| Message-ID: | 497CA7D6.90705@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Simon Riggs wrote:
>> 2. Kill all connections by given user. Hmm, not used for anything,
>> actually. Should remove the roleId argument from GetConflictingVirtualXIDs.
>
> No, because we still need to add code to kill-connected-users if we drop
> role.
Oh, I see, that's still a todo item. But we don't do that during normal
operation, so why should we during recovery?
>> I'm thinking of an interface
>> consisting of three functions, replacing the current
>> GetConflictingVirtualXIDs and ResolveRecoveryConflictWithVirtualXIDs
>> functions:
>
> I'm not sure I see any benefit in doing that.
It makes the code more readable.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-01-25 17:57:01 | Re: 8.4 release planning (was Re: [COMMITTERS] pgsql: Automatic view update rules) |
| Previous Message | Bernd Helmle | 2009-01-25 17:29:54 | Re: [COMMITTERS] pgsql: Automatic view update rules Bernd Helmle |