Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Hiroshi Inoue <inoue(at)tpf(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.
Date: 2009-01-21 15:54:41
Message-ID: 49774541.5070104@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> Peter Eisentraut wrote:
>> Magnus Hagander wrote:
>>> However, one question: The comment currently says it's harmless to do
>>> this on non-windows platforms. Does this still hold true?
>> Yes, the non-WIN32 code path appears to be the same, still. But the
>> ifdef WIN32 part we don't want, because that presumes something about
>> the spelling of encoding names in the local iconv library.
>>
>>> If we do keep the thing win32 only, I think we should just wrap the
>>> whole thing in #ifdef WIN32 and no longer do the codeset stuff at all on
>>> Unix - that'll make for cleaner code.
>> Yes, that would be much better.
>
> Something like this then?

Looks OK to me.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Hiroshi Inoue 2009-01-22 09:00:00 Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext() to the UTF8 locale when in use.
Previous Message User C2main 2009-01-21 15:26:06 muninpgplugins - muninpgplugins: tagging 0.2.1 (fix stat_database)

Browse pgsql-hackers by date

  From Date Subject
Next Message Todd A. Cook 2009-01-21 16:01:24 Re: is 8.4 array_agg() supposed to work with array values?
Previous Message Simon Riggs 2009-01-21 15:44:15 Re: Pluggable Indexes