Re: Patch for pgScript

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Mickael Deloison <mdeloison(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for pgScript
Date: 2009-01-21 13:44:38
Message-ID: 497726C6.3090504@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

CC:ing your explanation back to the list for others to see.

//Magnus

Mickael Deloison wrote:
> Hi,
>
> This is just meant for having same length as the other messages :
> [PGSQUERY], [PGSWARNG], [PGSEXCPT]
> If you do not like that, I (or you) can change it. Keep me posted.
>
> Regards,
> Mickael
>
> 2009/1/21 Magnus Hagander <magnus(at)hagander(dot)net>:
>> Hi!
>>
>> Sorry for the delay in reviewing.
>>
>> Does using "[PGSWARNG]" really make sense? It saves only *two*
>> characters over the much more readanle "[PGSWARNING]"
>>
>>
>> //Magnus
>>
>> Mickael Deloison wrote:
>>> Hi pgadmin hackers,
>>>
>>> First, let me wish you a very happy new year 2009.
>>>
>>> Then, here is a patch for the pgScript part of pgAdmin:
>>> Features:
>>> - Use of pgAdmin UI to highlight the line where an error occurred
>>> (frmQuery, pgsDriver, pgsThread, pgsApplication, pgsStmtList)
>>> - Possibility to execute only one part of the script by selecting it (frmQuery)
>>> - Changed output style (exceptions/*, expressions/pgsExecute,
>>> statements/pgsStmtList)
>>> - Improved the script for integration tests: it does not print the
>>> executed queries anymore because the output was too messy
>>> (xtra/pgscript/file/test/execute.sh)
>>> Bugs:
>>> - Fixed print statement which caused a lock in case an exception was
>>> thrown (statement/pgsPrintStmt)
>>>
>>> Best regards,
>>> Mickael
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-01-21 13:46:37 Re: Patch for pgScript
Previous Message Dave Page 2009-01-21 13:38:04 Re: Patch for pgScript