Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Reduce noise from tsort

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, Martijn van Oosterhout <kleptog(at)svana(dot)org>
Subject: Re: [PATCH] Reduce noise from tsort
Date: 2006-04-19 23:18:40
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Tom Lane wrote:
>> Well, I vote we take it out, which would eliminate these warnings
>> instead of just shorten them.  On a platform where tsorting a
>> non-shared library's contents is actually essential, libpq.a would be
>> useless anyway

> I don't think that the primary purpose of tsort/lorder is to produce a 
> functioning library.  The idea is to reduce the link time when the 
> library is later used by reducing the number of passes that the link 
> editor has to make over the input libraries.

That is a revisionist view of history.  The GNU coreutils people,
for instance, remember it the same way I do:

(In practice, I'm not sure anyone still uses libpq.a at all, rather
than ...)

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2006-04-20 01:16:02
Subject: Cleaning up multiply-defined-symbol warnings on OS X
Previous:From: Peter EisentrautDate: 2006-04-19 20:46:59
Subject: Re: [PATCH] Reduce noise from tsort

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group